1
0
mirror of https://github.com/misskey-dev/misskey.git synced 2026-07-25 19:05:03 +02:00
SASAPIYO (SASAGAWA Kiyoshi) ae5d2d40d7 fix(backend): skip inbox activities without an actor instead of throwing TypeError (#17558)
* fix(backend): skip inbox activities without an actor instead of throwing TypeError

- guard getApId() against null/undefined (and fix the 'detemine' typo)
- skip actor-less inbox activities early with Bull.UnrecoverableError

Fixes #17557

* fix(backend): reject actor-less inbox activities at enqueue time

Per review feedback (#17558), move the actor presence check to the inbox
HTTP handler and drop the processor-side guard.

- ActivityPubServerService.inbox(): validate the request body from the
  loose (unknown) type and return 400 for structurally invalid activities
  (non-object / missing actor) instead of enqueueing a job that can never
  be authenticated. Avoids useless retries and TypeError noise.
- InboxProcessorService.process(): remove the actor null guard; IActivity.actor
  is non-null, so the check is unnecessary once enqueue is validated.
- getApId(): widen the parameter to include undefined so the existing null
  guard is type-honest (getOneApId can pass value[0] of an empty array).

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

---------

Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
2026-06-19 15:00:17 +09:00
2026-05-12 17:36:49 +09:00
2022-06-09 00:50:23 +09:00
🎨
2025-05-07 10:44:43 +09:00
2026-05-12 17:36:49 +09:00
2025-09-27 20:53:21 +09:00
2026-06-18 18:41:00 +09:00
2025-10-19 11:34:34 +09:00
2026-01-05 20:56:52 +09:00
2025-07-16 15:49:05 +09:00
2026-06-04 19:40:20 +09:00
2025-12-06 17:39:17 +09:00
2018-08-13 00:24:45 +09:00
2023-02-26 14:17:29 +09:00
2026-05-15 10:12:17 +09:00
2018-03-28 22:56:28 +09:00
2026-06-17 03:21:46 +00:00
2019-04-05 18:17:30 +09:00
2026-01-07 21:43:31 +09:00
2025-11-11 09:30:13 +09:00
2025-02-01 13:57:39 +09:00

Misskey logo

🌎 Misskey is an open source, federated social media platform that's free forever! 🚀

Learn more


find an instance create an instance become a contributor join the community become a patron

Ask DeepWiki

Thanks

Sentry

Thanks to Sentry for providing the error tracking platform that helps us catch unexpected errors.

Chromatic

Thanks to Chromatic for providing the visual testing platform that helps us review UI changes and catch visual regressions.

Codecov

Thanks to Codecov for providing the code coverage platform that helps us improve our test coverage.

Crowdin

Thanks to Crowdin for providing the localization platform that helps us translate Misskey into many languages.

Docker

Thanks to Docker for providing the container platform that helps us run Misskey in production.


Support us with a !

Star History Chart

Description
🌎 A completely free and open interplanetary microblogging platform 🚀
https://github.com/misskey-dev/misskey Readme AGPL-3.0 608 MiB
Languages
TypeScript 64.5%
Vue 29%
JavaScript 5.7%
GLSL 0.3%
SCSS 0.3%