Use for-of instead of forEach (#3583)

Co-authored-by: syuilo <syuilotan@yahoo.co.jp>
Co-authored-by: Acid Chicken (硫酸鶏) <root@acid-chicken.com>

src/client/app/desktop/views/pages/deck/deck.column.vue

@@ -224,7 +224,9 @@ export default Vue.extend({
 
 			if (this.menu) {
 				items.unshift(null);
-				this.menu.reverse().forEach(i => items.unshift(i));
+				for (const i of this.menu.reverse()) {
+					items.unshift(i);
+				}
 			}
 
 			return items;

src/client/app/desktop/views/pages/deck/deck.direct.vue

@@ -77,7 +77,9 @@ export default Vue.extend({
 				} else {
 					this.existMore = false;
 				}
-				notes.forEach(n => (this.$refs.timeline as any).append(n));
+				for (const n of notes) {
+					(this.$refs.timeline as any).append(n);
+				}
 				this.moreFetching = false;
 			});
 

src/client/app/desktop/views/pages/deck/deck.hashtag-tl.vue

@@ -102,7 +102,9 @@ export default Vue.extend({
 				} else {
 					this.existMore = false;
 				}
-				notes.forEach(n => (this.$refs.timeline as any).append(n));
+				for (const n of notes) {
+					(this.$refs.timeline as any).append(n);
+				}
 				this.moreFetching = false;
 			});
 

src/client/app/desktop/views/pages/deck/deck.list-tl.vue

@@ -104,7 +104,9 @@ export default Vue.extend({
 				} else {
 					this.existMore = false;
 				}
-				notes.forEach(n => (this.$refs.timeline as any).append(n));
+				for (const n of notes) {
+					(this.$refs.timeline as any).append(n);
+				}
 				this.moreFetching = false;
 			});
 

src/client/app/desktop/views/pages/deck/deck.mentions.vue

@@ -75,7 +75,9 @@ export default Vue.extend({
 				} else {
 					this.existMore = false;
 				}
-				notes.forEach(n => (this.$refs.timeline as any).append(n));
+				for (const n of notes) {
+					(this.$refs.timeline as any).append(n);
+				}
 				this.moreFetching = false;
 			});
 

src/client/app/desktop/views/pages/deck/deck.notes.vue

@@ -164,7 +164,9 @@ export default Vue.extend({
 		},
 
 		releaseQueue() {
-			this.queue.forEach(n => this.prepend(n, true));
+			for (const n of this.queue) {
+				this.prepend(n, true);
+			}
 			this.queue = [];
 		},
 

src/client/app/desktop/views/pages/deck/deck.notifications.vue

@@ -142,7 +142,9 @@ export default Vue.extend({
 		},
 
 		releaseQueue() {
-			this.queue.forEach(n => this.prepend(n));
+			for (const n of this.queue) {
+				this.prepend(n);
+			}
 			this.queue = [];
 		},
 

src/client/app/desktop/views/pages/deck/deck.tl.vue

@@ -123,7 +123,9 @@ export default Vue.extend({
 				} else {
 					this.existMore = false;
 				}
-				notes.forEach(n => (this.$refs.timeline as any).append(n));
+				for (const n of notes) {
+					(this.$refs.timeline as any).append(n);
+				}
 				this.moreFetching = false;
 			});
 

src/client/app/desktop/views/pages/deck/deck.user-column.vue

@@ -167,11 +167,11 @@ export default Vue.extend({
 				limit: 9,
 				untilDate: new Date().getTime() + 1000 * 86400 * 365
 			}).then(notes => {
-				notes.forEach(note => {
-					note.files.forEach(file => {
+				for (const note of notes) {
+					for (const file of note.files) {
 						file._note = note;
-					});
-				});
+					}
+				}
 				const files = concat(notes.map((n: any): any[] => n.files));
 				this.images = files.filter(f => image.includes(f.type)).slice(0, 9);
 			});
@@ -298,7 +298,7 @@ export default Vue.extend({
 				} else {
 					this.existMore = false;
 				}
-				notes.forEach(n => (this.$refs.timeline as any).append(n));
+				for (const n of notes) (this.$refs.timeline as any).append(n);
 				this.moreFetching = false;
 			});
 

src/client/app/desktop/views/pages/search.vue

@@ -94,7 +94,9 @@ export default Vue.extend({
 				} else {
 					this.existMore = false;
 				}
-				notes.forEach(n => (this.$refs.timeline as any).append(n));
+				for (const n of notes) {
+					(this.$refs.timeline as any).append(n);
+				}
 				this.moreFetching = false;
 			});
 

src/client/app/desktop/views/pages/tag.vue

@@ -83,7 +83,9 @@ export default Vue.extend({
 				} else {
 					this.existMore = false;
 				}
-				notes.forEach(n => (this.$refs.timeline as any).append(n));
+				for (const n of notes) {
+					(this.$refs.timeline as any).append(n);
+				}
 				this.moreFetching = false;
 			});
 

src/client/app/desktop/views/pages/user/user.photos.vue

@@ -30,11 +30,11 @@ export default Vue.extend({
 			limit: 9,
 			untilDate: new Date().getTime() + 1000 * 86400 * 365
 		}).then(notes => {
-			notes.forEach(note => {
-				note.files.forEach(file => {
+			for (const note of notes) {
+				for (const file of note.files) {
 					if (this.images.length < 9) this.images.push(file);
-				});
-			});
+				}
+			}
 			this.fetching = false;
 		});
 	}

src/client/app/desktop/views/pages/user/user.timeline.vue

@@ -95,7 +95,9 @@ export default Vue.extend({
 				} else {
 					this.existMore = false;
 				}
-				notes.forEach(n => (this.$refs.timeline as any).append(n));
+				for (const n of notes) {
+					(this.$refs.timeline as any).append(n);
+				}
 				this.moreFetching = false;
 			});