mirrors/misskey
1
0
Fork 1
mirror of https://github.com/misskey-dev/misskey.git synced 2026-05-17 06:45:36 +02:00
Code Releases Activity

enhance(backend): request ip が localhost だった場合、レートリミットをスキップ & 警告を出すように

Browse Source
This commit is contained in:
syuilo
2025-12-16 19:56:44 +09:00
parent 8d871a58e3
commit d35ddc77d2
3 changed files with 37 additions and 25 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
packages/backend/src/server/api/ApiCallService.ts
View File

@@ -313,12 +313,16 @@ export class ApiCallService implements OnApplicationShutdown {
}
if (ep.meta.limit) {
// koa will automatically load the `X-Forwarded-For` header if `proxy: true` is configured in the app.
let limitActor: string;
let limitActor: string | null;
if (user) {
limitActor = user.id;
} else {
limitActor = getIpHash(request.ip);
if (request.ip === '::1' || request.ip === '127.0.0.1') {
console.warn('request ip is localhost, maybe caused by misconfiguration of trustProxy or reverse proxy');
limitActor = null;
} else {
limitActor = getIpHash(request.ip);
}
}
const limit = Object.assign({}, ep.meta.limit);
@@ -330,7 +334,7 @@ export class ApiCallService implements OnApplicationShutdown {
// TODO: 毎リクエスト計算するのもあれだしキャッシュしたい
const factor = user ? (await this.roleService.getUserPolicies(user.id)).rateLimitFactor : 1;
if (factor > 0) {
if (limitActor != null && factor > 0) {
// Rate limit
const rateLimit = await this.rateLimiterService.limit(limit as IEndpointMeta['limit'] & { key: NonNullable<string> }, limitActor, factor);
if (rateLimit != null) {