mirror of
https://github.com/misskey-dev/misskey.git
synced 2026-05-04 14:16:03 +02:00
fix(backend): handle array or string in alsoKnownAs (#17275)
* fix: handle array or string in alsoKnownAs, closes #17274 * style: use more idiomatic toArray() for UserEntityService handling of alsoKnownAs * fix: handle array-valued or unwrapped alsoKnownAs in ApPersonService * doc: note about bugfix for alsoKnownAs
This commit is contained in:
@@ -224,6 +224,51 @@ describe('ActivityPub', () => {
|
||||
});
|
||||
});
|
||||
|
||||
describe('alsoKnownAs field', () => {
|
||||
test('Handle alsoKnownAs as an array', async () => {
|
||||
const actor = {
|
||||
...createRandomActor(),
|
||||
alsoKnownAs: ['https://example.com/users/alice', 'https://example.com/users/alice2'],
|
||||
};
|
||||
|
||||
resolver.register(actor.id, actor);
|
||||
|
||||
const user = await personService.createPerson(actor.id, resolver);
|
||||
|
||||
assert.deepStrictEqual(user.alsoKnownAs, actor.alsoKnownAs);
|
||||
});
|
||||
|
||||
test('Handle alsoKnownAs as a string', async () => {
|
||||
const actor = {
|
||||
...createRandomActor(),
|
||||
alsoKnownAs: 'https://example.com/users/alice',
|
||||
};
|
||||
|
||||
resolver.register(actor.id, actor);
|
||||
|
||||
const user = await personService.createPerson(actor.id, resolver);
|
||||
|
||||
assert.deepStrictEqual(user.alsoKnownAs, [actor.alsoKnownAs]);
|
||||
});
|
||||
|
||||
test('Update person with alsoKnownAs as a string', async () => {
|
||||
const actor = createRandomActor();
|
||||
resolver.register(actor.id, actor);
|
||||
const user = await personService.createPerson(actor.id, resolver);
|
||||
|
||||
const updatedActor = {
|
||||
...actor,
|
||||
alsoKnownAs: 'https://example.com/users/alice',
|
||||
};
|
||||
resolver.register(actor.id, updatedActor);
|
||||
|
||||
await personService.updatePerson(actor.id, resolver, updatedActor);
|
||||
|
||||
const updatedUser = await personService.fetchPerson(actor.id);
|
||||
assert.deepStrictEqual(updatedUser?.alsoKnownAs, [updatedActor.alsoKnownAs]);
|
||||
});
|
||||
});
|
||||
|
||||
describe('Collection visibility', () => {
|
||||
test('Public following/followers', async () => {
|
||||
const actor = createRandomActor();
|
||||
|
||||
@@ -248,6 +248,16 @@ describe('UserEntityService', () => {
|
||||
expect(actual.achievements).toEqual(achievements);
|
||||
});
|
||||
|
||||
test('alsoKnownAs as string does not throw', async () => {
|
||||
const me = await createUser();
|
||||
const who = await createUser();
|
||||
|
||||
const whoWithStringAlsoKnownAs: MiUser = { ...who, alsoKnownAs: 'https://remote.example.com/users/alice' as any };
|
||||
|
||||
const actual = await service.pack(whoWithStringAlsoKnownAs, me, { schema: 'UserDetailedNotMe' }) as any;
|
||||
expect(Array.isArray(actual.alsoKnownAs)).toBe(true);
|
||||
});
|
||||
|
||||
describe('packManyによるpreloadがある時、preloadが無い時とpackの結果が同じになるか見たい', () => {
|
||||
test('no-preload', async() => {
|
||||
const me = await createUser();
|
||||
|
||||
Reference in New Issue
Block a user