mirrors/misskey
1
0
Fork 1
mirror of https://github.com/misskey-dev/misskey.git synced 2026-05-05 07:45:54 +02:00
Code Releases Activity

fix(backend): RoleService.getAdministratorIds でユーザーIDが重複する問題を修正 (#17334)

Browse Source 
* fix(backend): adminロールが複数付いてても通知が重複しないように

* add tests

* Update Changelog

* ✌️

Co-Authored-by: lqvp <183242690+lqvp@users.noreply.github.com>

---------

Co-authored-by: lqvp <183242690+lqvp@users.noreply.github.com>
This commit is contained in:
かっこかり
2026-04-24 17:56:52 +09:00
committed by GitHub
parent 8a85ee1d45
commit 3a3057a1b1
4 changed files with 17 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

13
packages/backend/test/unit/RoleService.ts
View File

@@ -696,6 +696,19 @@ describe('RoleService', () => {
expect(adminIds).toHaveLength(0);
});
test('should not include duplicate user IDs if a user has multiple administrator roles', async () => {
const adminUser = await createUser();
const adminRole1 = await createRole({ name: 'admin1', isAdministrator: true });
const adminRole2 = await createRole({ name: 'admin2', isAdministrator: true });
await roleService.assign(adminUser.id, adminRole1.id);
await roleService.assign(adminUser.id, adminRole2.id);
const adminIds = await roleService.getAdministratorIds();
expect(adminIds).toEqual([adminUser.id]);
});
// TODO: rootユーザーは現在実装に含まれていないため、テストもそれに倣う
test('should not include the root user', async () => {
const rootUser = await createUser();