From 1cdd177478cc7531dfdb8f76b9a2d837681cba49 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?=E3=81=8B=E3=81=A3=E3=81=93=E3=81=8B=E3=82=8A?=
 <67428053+kakkokari-gtyih@users.noreply.github.com>
Date: Tue, 14 Jul 2026 17:07:18 +0900
Subject: [PATCH] Apply suggestions from code review

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
---
 packages/frontend/src/components/MkNoteDetailed.vue | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/packages/frontend/src/components/MkNoteDetailed.vue b/packages/frontend/src/components/MkNoteDetailed.vue
index ceeefd69c2..8069867a38 100644
--- a/packages/frontend/src/components/MkNoteDetailed.vue
+++ b/packages/frontend/src/components/MkNoteDetailed.vue
@@ -70,7 +70,7 @@ SPDX-License-Identifier: AGPL-3.0-only
 							<MkAcct :user="appearNote.user"/>
 						</div>
 						<div v-if="badgeRoles" :class="$style.noteHeaderBadgeRoles">
-							<img v-for="(role, i) in badgeRoles" :key="i" v-tooltip="role.name" :class="$style.noteHeaderBadgeRole" :src="role.iconUrl!"/>
+							<img v-for="role in badgeRoles" :key="role.id" v-tooltip="role.name" :class="$style.noteHeaderBadgeRole" :src="role.iconUrl!"/>
 						</div>
 					</div>
 					<MkInstanceTicker v-if="showTicker" :host="appearNote.user.host" :instance="appearNote.user.instance"/>
@@ -335,10 +335,10 @@ const tab = ref(props.initialTab);
 const reactionTabType = ref<string | null>(null);
 const badgeRoles = computed(() => {
 	const roles = appearNote.user.badgeRoles;
-	if (roles == null || $i == null || $i.id !== props.note.userId) return roles;
+	if (roles == null || $i == null || $i.id !== appearNote.userId) return roles;
 
-	// 自分のプロフィールを自分で見た場合レスポンスに非表示ロールも含まれるので、別途除外する必要がある
-	const hiddenRoleIds = new Set(($i.hiddenRoleIds) ?? []);
+	// 自分のノートを自分で見た場合レスポンスに非表示ロールも含まれるので、別途除外する必要がある
+	const hiddenRoleIds = new Set($i.hiddenRoleIds ?? []);
 	return roles.filter(role => !hiddenRoleIds.has(role.id));
 });